metadata() for global metadata access #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2024
node-services protocol is meant for internal restate communication. pb/ appears to go beyond the internal cluster scope.
We need to consolidate a few bits of the system into a core crate to avoid the unnecessary dependency management hassle. The end goal is to consolidate many of the shared components into this crate. At the moment, task-center and metadata appear to be the best candidate since they are used from everywhere.
as described in the previous PR in the stack
tillrohrmann
approved these changes
Feb 23, 2024
crates/node/src/lib.rs
Outdated
| @@ -133,6 +133,8 @@ impl Node { | |||
| let tc = task_center(); | |||
| let metadata_writer = self.metadata_manager.writer(); | |||
| let metadata = self.metadata_manager.metadata(); | |||
| let is_set = tc.try_set_global_metadata(metadata.clone()); | |||
| debug_assert!(is_set); | |||
There was a problem hiding this comment.
Maybe add a short error message for easier debugging.
Access to metadata has never been easier. Access `metadata()` by importing `restate_core::metadata`;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metadata() for global metadata access
Access to metadata has never been easier. Access
metadata()by importingrestate_core::metadata;Stack created with Sapling. Best reviewed with ReviewStack.