Interface refactor #1248
Interface refactor #1248
Conversation
slinkydeveloper
force-pushed
the
interface-refactor
branch
from
5e79e88
to
6a4e650
Compare
Test Results 94 files 94 suites 3m 36s ⏱️ Results for commit 8f125ea. ♻️ This comment has been updated with latest results. |
slinkydeveloper
force-pushed
the
interface-refactor
branch
2 times, most recently
from
3341559
to
7a9bf9f
Compare
slinkydeveloper
force-pushed
the
interface-refactor
branch
2 times, most recently
from
d5a763b
to
541544a
Compare
|
I've tested the branch with restatedev/e2e#272 and restatedev/sdk-java#236 and e2e tests are passing! |
slinkydeveloper
force-pushed
the
interface-refactor
branch
from
541544a
to
63016b4
Compare
|
Checked after the rebase, everything works |
Remove old_tests in schemas_impl
This refactor includes using latest tower version, remove manual CORS handling code, and reorganize the handler code. Also includes the first bits to support awakeables resolution.
slinkydeveloper
force-pushed
the
interface-refactor
branch
from
63016b4
to
8f125ea
Compare
| let services = client.get_components().await?.into_body().await?.components; | ||
| for svc in services { |
There was a problem hiding this comment.
nit: services -> components, svc -> component
| for svc in deployment.components { | ||
| let Some(latest_svc) = latest_services.get(&svc.name) else { |
There was a problem hiding this comment.
nit: Renaming (service -> component) seems to be not complete. Won't mention it anymore.
There was a problem hiding this comment.
I'm tracking this here #1225
| Cell::new(&method.output_type), | ||
| Cell::new(&handler.name), | ||
| Cell::new(handler.input_description.as_deref().unwrap_or("any")), | ||
| Cell::new(handler.output_description.as_deref().unwrap_or("any")), | ||
| ]); | ||
| } | ||
| table | ||
| } | ||
|
|
||
| pub fn create_service_methods_table_diff( |
There was a problem hiding this comment.
Should that be called create_component_handlers_table_diff to be consistent in our terminology?
| old_svc_methods: &[HandlerMetadata], | ||
| new_svc_methods: &[HandlerMetadata], |
There was a problem hiding this comment.
old_component_handlers?
| # Encoding/Decoding | ||
| bytes = { workspace = true } | ||
| serde = { workspace = true } | ||
| serde_with = { workspace = true } | ||
| serde_json = { workspace = true } |
There was a problem hiding this comment.
nit: I think we are no longer trying to group dependencies logically because it increases the maintenance burden and there is sometimes no clear grouping. What we try to do is to group restate dependencies and others together.
|
@tillrohrmann will address your comments in my next PR when I finish to get rid of all the proto stuff. |
No description provided.