Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace target with restate-data as the default storage directory #1277

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

tillrohrmann
Copy link
Contributor

@tillrohrmann tillrohrmann commented Mar 17, 2024

This fixes #1276.

@tillrohrmann tillrohrmann changed the title Issues/1276 Replace target with restate-data as the default storage directory Mar 17, 2024
@AhmedSoliman
Copy link
Contributor

What do you think about using the PlainNodeID as a sub-directory name under restate-data (e.g. restate-data/N0) to make it trivial to run multiple nodes on the same host?

@tillrohrmann
Copy link
Contributor Author

What do you think about using the PlainNodeID as a sub-directory name under restate-data (e.g. restate-data/N0) to make it trivial to run multiple nodes on the same host?

I think this makes a lot of sense. So instead of configuring the individual directories for different components separately, we would allow specifying something like a working directory (e.g. restate-data) where we create a subdirectory for the node (restate-data/N0) and then the different restate components could create subdirectories in the node-scoped working directory (restate-data/N0/db, restate-data/N0/logs, etc.).

This change requires a bit more work than what I did in this PR. Would you be ok, @AhmedSoliman, if I tackled it as a follow-up since it is not strictly required for the single node Restate setup?

@AhmedSoliman
Copy link
Contributor

@tillrohrmann absolutely, go for it.

@tillrohrmann
Copy link
Contributor Author

Merging this PR now.

@tillrohrmann tillrohrmann merged commit f0dd2e8 into restatedev:main Mar 21, 2024
2 checks passed
@tillrohrmann tillrohrmann deleted the issues/1276 branch March 21, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace default target directory with restate-data
2 participants