Make Storage::Transaction a GAT #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalshilman
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
👍 of making the transaction borrow the storage.
I think that it now represents better the relationship between a transaction and the storage.
Even thinking forward for other implementations like PG etc' the transaction's life time needs to capture the storage lifetime.
LGTM!
By making the Storage::Transaction a GAT, we can now create Transaction implementations which don't need to own their data, because the Transaction can borrow from Storage. This fixes #737.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making the Storage::Transaction a GAT, we can now create Transaction implementations which don't need to own their data, because the Transaction can borrow from Storage. For the current
RocksDBTransactionimplementation which internally usesspawn_blockingit does not make a difference.This fixes #737.