Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial state flag #109

Closed
wants to merge 3 commits into from
Closed

Partial state flag #109

wants to merge 3 commits into from

Conversation

slinkydeveloper
Copy link
Contributor

@slinkydeveloper
Squashed 'sdk-core-impl/src/main/service-protocol/' changes from d101…
9e6bcf4 
…d48..1af5f12

1af5f12 Move the partial state flag in the StartMessage fields (#38)
e7ecb04 Add license (#48)

git-subtree-dir: sdk-core-impl/src/main/service-protocol
git-subtree-split: 1af5f12ff2eb015aabc7d735881ce74e22cbdf6f
@slinkydeveloper
Merge commit '9e6bcf43107ab36615bb3df31c7ec9d88ef57827' into partial_…
c39a681 
…state_flag
@slinkydeveloper
Use the StartMessage.partial_state flag, Remove partial_state flag pa…
a8a2f20 
…rsing
@github-actions
Copy link
Contributor

Unit Test Results

145 tests  ±0   145 ✔️ ±0   8s ⏱️ -2s
  15 suites ±0       0 💤 ±0 
  15 files   ±0       0 ❌ ±0 

Results for commit a8a2f20. ± Comparison against base commit 10781be.

tillrohrmann
tillrohrmann approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

@slinkydeveloper
Copy link
Contributor Author

Manually merged

@slinkydeveloper slinkydeveloper deleted the partial_state_flag branch September 6, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slinkydeveloper @tillrohrmann