Java/Kotlin docs for the new workflow api #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 14 files ±0 14 suites ±0 10s ⏱️ ±0s Results for commit 2eedc30. ± Comparison against base commit a8d7c68. This pull request removes 6 and adds 7 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
gvdongen
approved these changes
May 29, 2024
| * | ||
| * NOTE: This interface MUST NOT be accessed concurrently since it can lead to different orderings | ||
| * of user actions, corrupting the execution of the invocation. | ||
| */ |
There was a problem hiding this comment.
should we move a bit of this explanation to the ctx.promise JavaDocs? Because those are the ones you see first before clicking on the return type.
There was a problem hiding this comment.
This specific bit about not concurrent access is fine to keep it here.
sdk-api/src/main/java/dev/restate/sdk/SharedWorkflowContext.java
Outdated
Show resolved
Hide resolved
sdk-common/src/main/java/dev/restate/sdk/annotation/Shared.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus rename durablePromise/durablePromiseHandle to promise/promiseHandle