Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now send acks on combinators #334

Merged
merged 1 commit into from
May 29, 2024
Merged

Now send acks on combinators #334

merged 1 commit into from
May 29, 2024

Conversation

slinkydeveloper
Copy link
Contributor

Fix #207

Copy link
Contributor

github-actions bot commented May 29, 2024

Test Results

 48 files  +34   48 suites  +34   3m 2s ⏱️ + 2m 52s
746 tests +82  739 ✅ +82  7 💤 ±0  0 ❌ ±0 
747 runs  +82  740 ✅ +82  7 💤 ±0  0 ❌ ±0 

Results for commit 6d6eab5. ± Comparison against base commit a8d7c68.

This pull request removes 572 and adds 654 tests. Note that renamed tests count towards both.
dev.restate.sdk.JavaBlockingTests ‑ 100: [MockSingleThread][dev.restate.sdk.PromiseTest] AwaitPromise#run: Completed with failure
dev.restate.sdk.JavaBlockingTests ‑ 101: [MockMultiThreaded][dev.restate.sdk.PromiseTest] AwaitPromise#run: Completed with failure
dev.restate.sdk.JavaBlockingTests ‑ 102: [MockSingleThread][dev.restate.sdk.PromiseTest] PeekPromise#run: Completed with success
dev.restate.sdk.JavaBlockingTests ‑ 103: [MockMultiThreaded][dev.restate.sdk.PromiseTest] PeekPromise#run: Completed with success
dev.restate.sdk.JavaBlockingTests ‑ 104: [MockSingleThread][dev.restate.sdk.PromiseTest] PeekPromise#run: Completed with failure
dev.restate.sdk.JavaBlockingTests ‑ 105: [MockMultiThreaded][dev.restate.sdk.PromiseTest] PeekPromise#run: Completed with failure
dev.restate.sdk.JavaBlockingTests ‑ 106: [MockSingleThread][dev.restate.sdk.PromiseTest] PeekPromise#run: Completed with null
dev.restate.sdk.JavaBlockingTests ‑ 107: [MockMultiThreaded][dev.restate.sdk.PromiseTest] PeekPromise#run: Completed with null
dev.restate.sdk.JavaBlockingTests ‑ 108: [MockSingleThread][dev.restate.sdk.PromiseTest] IsCompletedPromise#run: Completed with success
dev.restate.sdk.JavaBlockingTests ‑ 109: [MockMultiThreaded][dev.restate.sdk.PromiseTest] IsCompletedPromise#run: Completed with success
…
dev.restate.e2e.JavaAwaitTimeoutTest ‑ Test Awaitable#await(Duration)
dev.restate.e2e.JavaAwakeableTest ‑ generate(IngressClient)
dev.restate.e2e.JavaCancelInvocationTest ‑ cancel blocked invocation on AWAKEABLE
dev.restate.e2e.JavaCancelInvocationTest ‑ cancel blocked invocation on CALL
dev.restate.e2e.JavaCancelInvocationTest ‑ cancel blocked invocation on SLEEP
dev.restate.e2e.JavaCoordinatorWithNodeReceiverServiceToServiceCallTest ‑ synchronousCall(IngressClient)
dev.restate.e2e.JavaErrorsTest ‑ Test calling method that fails terminally
dev.restate.e2e.JavaErrorsTest ‑ Test calling method that fails terminally multiple times
dev.restate.e2e.JavaErrorsTest ‑ Test invocations are retried until they succeed
dev.restate.e2e.JavaErrorsTest ‑ Test propagate failure from another service
…
This pull request removes 7 skipped tests and adds 7 skipped tests. Note that renamed tests count towards both.
dev.restate.sdk.http.vertx.HttpVertxTests ‑ 134: [HttpVertxTestExecutor][dev.restate.sdk.kotlin.DeferredTest] Unknown
dev.restate.sdk.http.vertx.HttpVertxTests ‑ 135: [HttpVertxTestExecutor][dev.restate.sdk.kotlin.DeferredTest] Unknown: Fires timeout
dev.restate.sdk.http.vertx.HttpVertxTests ‑ 168: [HttpVertxTestExecutor][dev.restate.sdk.kotlin.StateTest] Unknown
dev.restate.sdk.kotlin.KotlinCoroutinesTests ‑ 104: [MockSingleThread][dev.restate.sdk.kotlin.StateTest] Unknown
dev.restate.sdk.kotlin.KotlinCoroutinesTests ‑ 105: [MockMultiThreaded][dev.restate.sdk.kotlin.StateTest] Unknown
dev.restate.sdk.kotlin.KotlinCoroutinesTests ‑ 42: [MockMultiThreaded][dev.restate.sdk.kotlin.DeferredTest] Unknown
dev.restate.sdk.kotlin.KotlinCoroutinesTests ‑ 43: [MockMultiThreaded][dev.restate.sdk.kotlin.DeferredTest] Unknown: Fires timeout
dev.restate.sdk.http.vertx.HttpVertxTests ‑ 136: [HttpVertxTestExecutor][dev.restate.sdk.kotlin.DeferredTest] Unknown
dev.restate.sdk.http.vertx.HttpVertxTests ‑ 137: [HttpVertxTestExecutor][dev.restate.sdk.kotlin.DeferredTest] Unknown: Fires timeout
dev.restate.sdk.http.vertx.HttpVertxTests ‑ 171: [HttpVertxTestExecutor][dev.restate.sdk.kotlin.StateTest] Unknown
dev.restate.sdk.kotlin.KotlinCoroutinesTests ‑ 108: [MockSingleThread][dev.restate.sdk.kotlin.StateTest] Unknown
dev.restate.sdk.kotlin.KotlinCoroutinesTests ‑ 109: [MockMultiThreaded][dev.restate.sdk.kotlin.StateTest] Unknown
dev.restate.sdk.kotlin.KotlinCoroutinesTests ‑ 44: [MockMultiThreaded][dev.restate.sdk.kotlin.DeferredTest] Unknown
dev.restate.sdk.kotlin.KotlinCoroutinesTests ‑ 45: [MockMultiThreaded][dev.restate.sdk.kotlin.DeferredTest] Unknown: Fires timeout

♻️ This comment has been updated with latest results.

@slinkydeveloper slinkydeveloper merged commit 957c7b6 into main May 29, 2024
4 checks passed
@slinkydeveloper slinkydeveloper deleted the issues/207 branch May 29, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combinator entry must wait for ack
1 participant