Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getOutput return type #342

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

slinkydeveloper
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Jun 3, 2024

Test Results

682 tests   - 80   675 ✅  - 80   11s ⏱️ - 7m 0s
 14 suites  - 35     7 💤 ± 0 
 14 files    - 35     0 ❌ ± 0 

Results for commit 787f957. ± Comparison against base commit 5bba500.

This pull request removes 374 and adds 294 tests. Note that renamed tests count towards both.
dev.restate.e2e.JavaAwaitTimeoutTest ‑ Test Awaitable#await(Duration)
dev.restate.e2e.JavaAwakeableTest ‑ generate(Client)
dev.restate.e2e.JavaCancelInvocationTest ‑ cancel blocked invocation on AWAKEABLE
dev.restate.e2e.JavaCancelInvocationTest ‑ cancel blocked invocation on CALL
dev.restate.e2e.JavaCancelInvocationTest ‑ cancel blocked invocation on SLEEP
dev.restate.e2e.JavaCoordinatorWithNodeReceiverServiceToServiceCallTest ‑ synchronousCall(Client)
dev.restate.e2e.JavaErrorsTest ‑ Test calling method that fails terminally
dev.restate.e2e.JavaErrorsTest ‑ Test calling method that fails terminally multiple times
dev.restate.e2e.JavaErrorsTest ‑ Test invocations are retried until they succeed
dev.restate.e2e.JavaErrorsTest ‑ Test propagate failure from another service
…
dev.restate.sdk.JavaBlockingTests ‑ 116: [MockSingleThread][dev.restate.sdk.PromiseTest] IsCompletedPromise#run: Not completed
dev.restate.sdk.JavaBlockingTests ‑ 117: [MockMultiThreaded][dev.restate.sdk.PromiseTest] IsCompletedPromise#run: Not completed
dev.restate.sdk.JavaBlockingTests ‑ 118: [MockSingleThread][dev.restate.sdk.PromiseTest] ResolvePromise#run: resolve succeeds
dev.restate.sdk.JavaBlockingTests ‑ 119: [MockMultiThreaded][dev.restate.sdk.PromiseTest] ResolvePromise#run: resolve succeeds
dev.restate.sdk.JavaBlockingTests ‑ 120: [MockSingleThread][dev.restate.sdk.PromiseTest] ResolvePromise#run: resolve fails
dev.restate.sdk.JavaBlockingTests ‑ 121: [MockMultiThreaded][dev.restate.sdk.PromiseTest] ResolvePromise#run: resolve fails
dev.restate.sdk.JavaBlockingTests ‑ 122: [MockSingleThread][dev.restate.sdk.PromiseTest] RejectPromise#run: resolve succeeds
dev.restate.sdk.JavaBlockingTests ‑ 123: [MockMultiThreaded][dev.restate.sdk.PromiseTest] RejectPromise#run: resolve succeeds
dev.restate.sdk.JavaBlockingTests ‑ 124: [MockSingleThread][dev.restate.sdk.PromiseTest] RejectPromise#run: resolve fails
dev.restate.sdk.JavaBlockingTests ‑ 125: [MockMultiThreaded][dev.restate.sdk.PromiseTest] RejectPromise#run: resolve fails
…
This pull request removes 3 skipped tests and adds 3 skipped tests. Note that renamed tests count towards both.
dev.restate.sdk.http.vertx.HttpVertxTests ‑ 138: [HttpVertxTestExecutor][dev.restate.sdk.kotlin.DeferredTest] Unknown
dev.restate.sdk.http.vertx.HttpVertxTests ‑ 139: [HttpVertxTestExecutor][dev.restate.sdk.kotlin.DeferredTest] Unknown: Fires timeout
dev.restate.sdk.http.vertx.HttpVertxTests ‑ 175: [HttpVertxTestExecutor][dev.restate.sdk.kotlin.StateTest] Unknown
dev.restate.sdk.http.vertx.HttpVertxTests ‑ 137: [HttpVertxTestExecutor][dev.restate.sdk.kotlin.DeferredTest] Unknown
dev.restate.sdk.http.vertx.HttpVertxTests ‑ 138: [HttpVertxTestExecutor][dev.restate.sdk.kotlin.DeferredTest] Unknown: Fires timeout
dev.restate.sdk.http.vertx.HttpVertxTests ‑ 174: [HttpVertxTestExecutor][dev.restate.sdk.kotlin.StateTest] Unknown

♻️ This comment has been updated with latest results.

Copy link

@igalshilman igalshilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slinkydeveloper slinkydeveloper merged commit 52227b9 into main Jun 3, 2024
3 of 4 checks passed
@slinkydeveloper slinkydeveloper deleted the issues/get-output-optional branch June 3, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants