Fix end span #77
Merged
Fix end span #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results100 tests ±0 100 ✔️ ±0 8s ⏱️ +3s Results for commit 81c3a26. ± Comparison against base commit 2ac7894. This pull request removes 62 and adds 62 tests. Note that renamed tests count towards both. |
tillrohrmann
approved these changes
Mar 21, 2023
slinkydeveloper
added a commit
that referenced
this pull request
Mar 22, 2024
….29b28f98 29b28f98 Modify Input/Output schema in deployment_manifest_schema.json (#80) 26d91e69 Replace protocol Empty message with custom one, so we remove the dependency on protobuf built-in messages (#79) 61ae44b2 Update documentation on error codes (#77) 576a1b26 Add HandlerType. Fix #1092 (#76) 0624d092 Payload schema for input and output. This provides basic format awareness. (#74) git-subtree-dir: sdk-core/src/main/service-protocol git-subtree-split: 29b28f9867734bc01dd47c4666d9d56c90b626f5
slinkydeveloper
added a commit
that referenced
this pull request
Mar 22, 2024
* Squashed 'sdk-core/src/main/service-protocol/' changes from 4378d559..29b28f98 29b28f98 Modify Input/Output schema in deployment_manifest_schema.json (#80) 26d91e69 Replace protocol Empty message with custom one, so we remove the dependency on protobuf built-in messages (#79) 61ae44b2 Update documentation on error codes (#77) 576a1b26 Add HandlerType. Fix #1092 (#76) 0624d092 Payload schema for input and output. This provides basic format awareness. (#74) git-subtree-dir: sdk-core/src/main/service-protocol git-subtree-split: 29b28f9867734bc01dd47c4666d9d56c90b626f5 * Changes due to the protocol update
slinkydeveloper
added a commit
that referenced
this pull request
Apr 16, 2024
….98bd326c 98bd326c Entry names + specify the entry that caused the failure in ErrorMessage (#86) c47e65b0 Describe x-restate-user-agent (#85) d43de04c Describe side effects in protocol (#84) 29b28f98 Modify Input/Output schema in deployment_manifest_schema.json (#80) 26d91e69 Replace protocol Empty message with custom one, so we remove the dependency on protobuf built-in messages (#79) 61ae44b2 Update documentation on error codes (#77) 576a1b26 Add HandlerType. Fix #1092 (#76) 0624d092 Payload schema for input and output. This provides basic format awareness. (#74) git-subtree-dir: sdk-core/src/main/service-protocol git-subtree-split: 98bd326c23f060d962821bca982bbb881e32c540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without
span.end(), the span is never committed.