Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator specific Trigger-Type Ro interface AVP value #21

Closed
gfigiel opened this issue Feb 7, 2017 · 2 comments
Closed

Operator specific Trigger-Type Ro interface AVP value #21

gfigiel opened this issue Feb 7, 2017 · 2 comments

Comments

@gfigiel
Copy link
Contributor

gfigiel commented Feb 7, 2017

Hello,
We have implemented extensions to diameter Ro RA. In scope of the project we implemented additional (non-standard) value for Trigger-Type AVP.
The value is 999 (new emum created) and causes diameter session to be served in degraded mode.

We agreed our Customer to contribute this extension so the question is to community now... Shall we include non-standard extensions to current diameter implementation?
gfigiel pushed a commit to ProIDS/jain-slee.diameter that referenced this issue Feb 7, 2017
Fix for issue RestComm#21 Trigger-Type AVP values alligned with 3GPP …
893b12b 
…TS 32.299 V8.25.0 and custom value (999) implemented.
@gfigiel
Copy link
Contributor Author

gfigiel commented Feb 7, 2017

Hello,
Please see the PR for this issue. I believe there is no much backward compatibility issue risk.
The only issue I can see is in scenario when some peer will generate the same, erronous AVP value by conicidence and it will be wrongly accepted by stack (customized) instead of raise an Exception.

@deruelle
Copy link
Member

Closed from #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deruelle @gfigiel