RESTEASY-2194 fixing CDI property injector to always work on contextu… #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoldano
requested changes
Mar 19, 2019
resteasy-cdi/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.jboss.weld</groupId> | ||
| <artifactId>weld-api</artifactId> | ||
| <version>3.1.Final</version> |
There was a problem hiding this comment.
Please remove the version element here and let the dependencies bom control it
istudens
force-pushed
the
WFLY-11680_master2
branch
from
c890a0e
to
c2a7736
Compare
|
Done. Thanks for review. |
|
@istudens thanks; please note this also needs to be rebased against master now |
|
@asoldano It should be. I did rebase it against master and the other one against 3.7. |
…al instance instead of client proxy
istudens
force-pushed
the
WFLY-11680_master2
branch
from
c2a7736
to
795e297
Compare
|
I've just rebased both PRs again. |
asoldano
approved these changes
Mar 20, 2019
|
Thanks @istudens , I've merged the PR. That said, any chance you can also provide an integration test for this? |
|
@asoldano Sure, I have a testcase in EAP testsuite, but I am working on a testcase in RestEasy directly. I will get back to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…al instance instead of client proxy
https://issues.jboss.org/browse/RESTEASY-2194