[RESTEASY-1205] RestEasy-Netty4: ByteBuf leak in ResteasyHttpRequestDecoder

[gustavocoding]

https://issues.jboss.org/browse/RESTEASY-1205

[AlexKolpa]

This implementation holds onto the ByteBuf until the entire response has been closed. I'm pretty sure that once the content has been read, it can be closed. So that would be right after this line.

Unfortunately, there's no easy way to get access to the NettyHttpRequest with the currently implementation. One option would be to pass it to the AbstractReaderInterceptorContext from ServerReaderInterceptorContext.

Preferably you'd want this commit in netty to be available, so you'd just need to call new ByteBufInputStream(buff, true) in RestEasyHttpRequestDecoder, and then an inputStream.close() after having read the content in AbstractReaderInterceptorContext

[gustavocoding]

@AlexKolpa that commit will surely help, thanks for pointing it out. It apparently will be on next Netty 4.1.x version, but in the meantime, holding the ByteBuf until after the response is closed is certainly better than never releasing the ByteBuf

[crazyzh1984]

Too complex implemention.
I have a simpler implemention on pull request #998
commit b8db623 @asoldano

My implemention will also easy to migrating to the latest netty,
using new ByteBufInputStream(buff, true) referenced by @AlexKolpa

[asoldano]

@crazyzh1984 actually I found the impl here simpler, anyway, if you feel there's a need for and want to provide an additional improvement PR on top this, feel free to open that up. Thanks.