Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checker to ensure that the servletContext is just loaded once. #17 #18

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Add checker to ensure that the servletContext is just loaded once. #17 #18

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
424b288
Add checker to ensure that the servletContext is just loaded once. #17
liweinan Aug 10, 2023
cd0d9c7
add `final` to the flag
liweinan Aug 10, 2023
bb078d2
the flag should be static
liweinan Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions grpc-bridge/src/main/java/dev/resteasy/grpc/bridge/generator/ServerGrpcGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ public String generate() throws IOException {
.writeLine("import jakarta.servlet.http.HttpServletRequest;")
.writeLine("import jakarta.ws.rs.GET;")
.writeLine("import jakarta.ws.rs.Path;")
.writeLine("import jakarta.ws.rs.core.Context;");
.writeLine("import jakarta.ws.rs.core.Context;")
.writeLine("import java.util.concurrent.atomic.AtomicBoolean;");
// Import the service implementation
final String serviceImplName;
if (packageName.endsWith(".")) {
Expand All @@ -79,7 +80,8 @@ public String generate() throws IOException {
"private static final Logger logger = Logger.getLogger(", prefix, "_Server.class.getName());")
.writeLine("private static ServletContext servletContext;")
.writeLine("private static int PORT = 8082;")
.writeLine("private Server server;");
.writeLine("private Server server;")
.writeLine("private static final AtomicBoolean servletContextInitialized = new AtomicBoolean(false);");

// Write the main method
writer.writeLine("/**")
Expand All @@ -99,8 +101,12 @@ public String generate() throws IOException {
writer.writeLine("@Path(\"context\")")
.writeLine("@GET")
.startBlock("public String startContext(@Context HttpServletRequest request) throws Exception {")
.writeLine("if (!servletContextInitialized.getAndSet(true)) {")
.writeLine("servletContext = request.getServletContext();")
.writeLine("return \"Got \" + this + \" servletContext\";")
.writeLine("} else {")
.writeLine("return this + \" servletContext already initialized.\";")
.writeLine("}")
.endBlock()
.writeLine();

Expand Down