New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RESTEASY-3006 Allow microprofile-client to inject Vertx engine for HTTP/2 communication #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this looks okay. I want to think about if we can get it to work without having to use the RestClientBuilderImpl
directly. One thing that comes to mind is doing something like:
HttpClientOptions options = new HttpClientOptions();
options.setSsl(true);
options.setProtocolVersion(HttpVersion.HTTP_2);
options.setUseAlpn(true);
builder.setProperty("org.jboss.resteasy.http.client.engine", new VertxClientHttpEngine(Vertx.vertx(), options));
Then the RestClientBuilderImpl
itself looks for the property. It requires knowledge of the ClientHttpEngine
, but that seems okay as that is a public API and IMO the RestClientBuilderImpl
should not be a public API.
@jamezp Unfortunately Shall I submit a request to add a method into the interface to the eclipse community? Is there any workflow to submit it? |
There should be as it extends |
@jamezp Thanks for the suggestion! I'll go on working on this :D |
...-client-base/src/main/java/org/jboss/resteasy/microprofile/client/RestClientBuilderImpl.java
Outdated
Show resolved
Hide resolved
@jamezp I have modified all the places you've mentioned, could you please help to do a final check? Thanks! :D (the test error in above I checked is because of Github CI platform network problem) After this PR is merged I'll:
|
@jamezp I merged the PR, if there is any problem pls let me know. |
resolves #8