Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RESTEASY-2003] Isolate container standalone dir in tests #1684

Merged
merged 2 commits into from Sep 3, 2018

Conversation

jbliznak
Copy link
Contributor

@jbliznak jbliznak commented Sep 3, 2018

https://issues.jboss.org/browse/RESTEASY-2003

To isolate the instance specific stuff I had to introduce few more steps for copying the standalone directory and retarget few plugin runs to different phases so that all is executed in proper order.

Copy link
Member

@asoldano asoldano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbliznak for the problem investigation and the PR. I'm approving this as it basically works and I want to move forward and enable WildFly 14 testing. This said, I believe we should be improving the solution here. Is it really needed to copy the whole server distribution directory? What we really need are just copies of the standalone.xml file that use different log files, the same we do in JBossWS, right?

@asoldano asoldano merged commit 0a26533 into resteasy:master Sep 3, 2018
@asoldano asoldano added the main label Sep 3, 2018
@jbliznak
Copy link
Contributor Author

jbliznak commented Sep 3, 2018

We are not copying whole server (WF_HOME) here, just the standalone dir (WF_HOME/standalone). For vanilla distribution that was never started it is under 1MB so I guess this is ok.

Sure, we can introduce alternative solution, for WF14 the minimum seems to be own standalone/data directory (-Djboss.server.data.dir) per instance because that is the place where the lock files is ++ own standalone-full.xml ++ specify instance specific log file or log dir (-Djboss.server.log.dir). This could save some space in exchange for more complex configuration in pom.xml.

Given we didn't even need the isolated data dir for WF13-, who knows what can change in future releases. I believe I chose the second safest way (the first being copying the whole server distribution) while keeping the size reasonable.

@asoldano
Copy link
Member

asoldano commented Sep 4, 2018

@jbliznak , sorry, I overlooked that; so I agree with you, it's perfectly fine like this, cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants