-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RESTEASY-2573] ResteasyContext never popped for SSE async streams #2383
Conversation
@FroMage, just yesterday I restored the tests that were excluded because of RESTEASY-2542 and we also moved to GitHub actions for the CI testing. Unfortunately, it looks like we still have intermittent SSE test failures. So, first of all I'd ask you if you can rebase this PR against master as I've excluded again one test that seem to fail very frequently. Then we should investigate the failures (I'm asking Jim too as soon as he's back from holiday). Moreover, if you want to test this PR with the old TravisCI solution, we can do that as well (just let me know). Thanks. |
@asoldano I just rebased on master. Do I need to do anything to get CI to run on GitHub Actions instead of Travis? I see travis kicked in, for some reason. |
Failure:
|
@FroMage thanks for the rebase. Now, here as well as on master, GithubActions runs are enabled. You see also a travis run with a single job for the Elytron integration testing only. |
I know it's not been long, but is there any rough ETA on this one? |
@WillSmithTE , I can't say for sure, but I believe this will be included in next release of 4.x series, which should come fairly soon. |
@FroMage , can you please rebase again? |
Done. |
Fix for https://issues.redhat.com/projects/RESTEASY/issues/RESTEASY-2573