Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RESTEASY-2573] ResteasyContext never popped for SSE async streams #2383

Merged
merged 2 commits into from
May 15, 2020

Conversation

FroMage
Copy link
Contributor

@FroMage FroMage commented May 5, 2020

@asoldano
Copy link
Member

asoldano commented May 5, 2020

@FroMage, just yesterday I restored the tests that were excluded because of RESTEASY-2542 and we also moved to GitHub actions for the CI testing. Unfortunately, it looks like we still have intermittent SSE test failures. So, first of all I'd ask you if you can rebase this PR against master as I've excluded again one test that seem to fail very frequently. Then we should investigate the failures (I'm asking Jim too as soon as he's back from holiday). Moreover, if you want to test this PR with the old TravisCI solution, we can do that as well (just let me know). Thanks.

@FroMage
Copy link
Contributor Author

FroMage commented May 6, 2020

@asoldano I just rebased on master. Do I need to do anything to get CI to run on GitHub Actions instead of Travis? I see travis kicked in, for some reason.

@FroMage
Copy link
Contributor Author

FroMage commented May 6, 2020

Failure:

2020-05-06T12:36:03.9790684Z [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test (default-test) on project resteasy-unit-tests: Unable to generate classpath: org.apache.maven.artifact.resolver.ArtifactResolutionException: Unable to get dependency information for org.apache.maven.surefire:surefire-junit47:jar:2.22.0: Failed to retrieve POM for org.apache.maven.surefire:surefire-junit47:jar:2.22.0: Could not transfer artifact org.apache.maven.surefire:surefire-junit47:pom:2.22.0 from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-junit47/2.22.0/surefire-junit47-2.22.0.pom

@asoldano
Copy link
Member

asoldano commented May 6, 2020

@FroMage thanks for the rebase. Now, here as well as on master, GithubActions runs are enabled. You see also a travis run with a single job for the Elytron integration testing only.
Earlier today I've created a branch for reproducing the SSE failures with the old Travis only (#2387 ) and got a failure on the first run, so I can say that the problem is there regardless of the CI mechanism being used.

@FroMage FroMage changed the title ResteasyContext never poped for SSE async streams ResteasyContext never popped for SSE async streams May 7, 2020
@WillSmithTE
Copy link

I know it's not been long, but is there any rough ETA on this one?

@asoldano
Copy link
Member

@WillSmithTE , I can't say for sure, but I believe this will be included in next release of 4.x series, which should come fairly soon.

@asoldano
Copy link
Member

@FroMage , can you please rebase again?

@asoldano asoldano changed the title ResteasyContext never popped for SSE async streams [RESTEASY-2573] ResteasyContext never popped for SSE async streams May 15, 2020
@FroMage
Copy link
Contributor Author

FroMage commented May 15, 2020

Done.

@asoldano asoldano merged commit d3b0e5e into resteasy:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants