[RESTEASY-2882] Changed the processing of ResponseExceptionMapper to … #2850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamezp
requested changes
Jun 21, 2021
There was a problem hiding this comment.
The test doesn't look quite right to me. I made some comments on it, but it also needs some kind of resource to invoke too. Something like:
@Path("/")
public class HealthResource {
@GET
@Path("/health")
@Produces(MediaType.APPLICATION_JSON)
public Response status() {
return Response.status(Response.Status.SERVICE_UNAVAILABLE).entity(new HealthCheckData("Down")).build();
}
}
.../test/java/org/jboss/resteasy/test/microprofile/restclient/Ignore503ExceptionMapperTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/jboss/resteasy/test/microprofile/restclient/Ignore503ExceptionMapperTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/jboss/resteasy/test/microprofile/restclient/Ignore503ExceptionMapperTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/jboss/resteasy/test/microprofile/restclient/Ignore503ExceptionMapperTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/jboss/resteasy/test/microprofile/restclient/Ignore503ExceptionMapperTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/jboss/resteasy/test/microprofile/restclient/Ignore503ExceptionMapperTest.java
Outdated
Show resolved
Hide resolved
...rofile-base/src/main/java/org/jboss/resteasy/microprofile/client/ProxyInvocationHandler.java
Show resolved
Hide resolved
...microprofile-base/src/main/java/org/jboss/resteasy/microprofile/client/ExceptionMapping.java
Show resolved
Hide resolved
|
Actually maybe you meant the 404 to be thrown which is why there wasn't a resource. If that is the case we should probably change the name of the test and the exception mapper to |
rsearls
force-pushed
the
RESTEASY-2882-MicroProfile-NULL-ResponseExceptionMapper
branch
from
4064a05
to
7d51459
Compare
|
Changes complete |
jamezp
reviewed
Jun 24, 2021
...est/java/org/jboss/resteasy/test/microprofile/restclient/ExceptionMapperReturnsNullTest.java
Show resolved
Hide resolved
rsearls
force-pushed
the
RESTEASY-2882-MicroProfile-NULL-ResponseExceptionMapper
branch
from
7d51459
to
bb72f69
Compare
jamezp
reviewed
Jun 24, 2021
...profile-base/src/main/java/org/jboss/resteasy/microprofile/client/RestClientBuilderImpl.java
Show resolved
Hide resolved
jamezp
reviewed
Jun 24, 2021
.../java/org/jboss/resteasy/test/microprofile/restclient/resource/Ignore503ExceptionMapper.java
Outdated
Show resolved
Hide resolved
…meet spec requirements
rsearls
force-pushed
the
RESTEASY-2882-MicroProfile-NULL-ResponseExceptionMapper
branch
from
bb72f69
to
b910728
Compare
jamezp
approved these changes
Jun 24, 2021
svenhaag
reviewed
Jul 20, 2021
| // falling through to here means no applicable exception mapper found | ||
| // or applicable mapper returned null | ||
| LOGGER.warnf("No default ResponseExceptionMapper found or user's ResponseExceptionMapper returned null." | ||
| + " Response status: %s messge: %s", handled.getStatus(), handled.getReasonPhrase()); |
svenhaag
reviewed
Jul 20, 2021
| @@ -151,6 +151,8 @@ public Object invoke(Object proxy, Method method, Object[] args) throws Throwabl | |||
| } | |||
| if (cause instanceof ExceptionMapping.HandlerException) { | |||
| ((ExceptionMapping.HandlerException)cause).mapException(method); | |||
| // no applicable exception mapper found or applicable mapper returned null | |||
There was a problem hiding this comment.
couldn't this be a debug log message too?
svenhaag
reviewed
Jul 20, 2021
| .getHealthData(); | ||
| Assert.fail("Exception should have been returned"); | ||
| } catch (Exception e) { | ||
| // success exception was returned |
There was a problem hiding this comment.
Assert the expected exception class would be cool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…meet spec requirements