[RESTEASY-3015] Avoid a payload byte[] copy when using reactor-netty HTTP client engine #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Some memory copying is avoided by directly connecting resteasy's request payload to the reactor-netty's 'outbound'. 2. Fix a bug where headers added by things like RestEasy MessageBodyWriters are appropriately added to the request that reactor-netty sends out. 3. If empty due to thread switching, establish ResteasyContext that has the Provider->ClientConfiguration such that Provider field level injection will work in when the request body is written. Much credit for these changes is owed to @anilgursel and @dnagarajan89.
And switch to a non-mutating injection technique.
Avoiding this was the main reason we started this work.
Co-authored-by: dhanagarajan <dhanagarajan@paypal.com>
…t-reactor-netty module. (#9) * Fixed PR comments * Moved TrackingMap and TrackingClientRequestHeaders to resteasy-client-reactor-netty module. Co-authored-by: dhanagarajan <dhanagarajan@paypal.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from #2902