[RESTEASY-3280] Do not load the ThreadContext's from a service loader… #3396
Conversation
… each time the contexts are required. https://issues.redhat.com/browse/RESTEASY-3280
| } | ||
| ThreadContexts threadContexts = ResteasyProviderFactory.getInstance().getContextData(ThreadContexts.class); | ||
| if (threadContexts == null) { | ||
| threadContexts = new ThreadContexts(); |
There was a problem hiding this comment.
Hi @jamezp . Did the customer say this fixed the issue? For us, we still see it going through the serviceloader for each request that flows through this. threadContexts always appears to be null. What am I missing?
There was a problem hiding this comment.
@crankydillo No, it didn't end up fixing it, https://issues.redhat.com/browse/RESTEASY-3313. It cut down on it, but didn't fix it. I'm going to have to see if there is a better place to put it.
I'm currently trying to see if it's reasonable to rewrite the entire context and ResteasyProviderFactory stuff now as I think there are better ways to handle it.
There was a problem hiding this comment.
As always, thanks for the fast-feedback! Apologies for not searching JIRA. I should have done that!
There was a problem hiding this comment.
No worries. I was looking at it yesterday so I had the JIRA up already in a tab :)
… each time the contexts are required.
https://issues.redhat.com/browse/RESTEASY-3280
Upstream #3395