Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query params to reqest for VertxClientHttpEngine #3568

Merged

Conversation

tylerscoville
Copy link
Contributor

@tylerscoville tylerscoville commented Apr 19, 2023

This pr pulls in a subset of changes from #2890

The changes are

  • Add query params to uri if they exist
  • Dont add USER_AGENT header if one already exists

https://issues.redhat.com/browse/RESTEASY-3018

@wildfly-ci
Copy link
Collaborator

Hello, tylerscoville. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

@jamezp
Copy link
Contributor

jamezp commented Apr 20, 2023

Thank you @tylerscoville!

We require all contributions to be made under the terms of the ASL 2.0 License: http://www.apache.org/licenses/LICENSE-2.0
Do you agree to these terms?

Also WRT to the PR, it looks like an mvn clean compile wasn't done or the formatting was skipped. Could you run that to let the formatter run and amend the commit?

@jamezp
Copy link
Contributor

jamezp commented Apr 20, 2023

/ok-to-test

@tylerscoville tylerscoville force-pushed the tscoville/vertx_client_engine_query_params branch from cecc000 to 7675a35 Compare April 20, 2023 17:32
@tylerscoville
Copy link
Contributor Author

@jamezp Thanks for getting back so fast.

I agree to the terms.

I also ran mvn clean compile and amended the commit.

@jamezp
Copy link
Contributor

jamezp commented Apr 20, 2023

The TCK failure is known and nothing to worry about.

@jamezp jamezp merged commit e374581 into resteasy:main Apr 20, 2023
15 of 16 checks passed
@jamezp
Copy link
Contributor

jamezp commented Apr 20, 2023

Thank you @tylerscoville

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants