Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertx server adapter #868

Merged
merged 3 commits into from Jul 26, 2016
Merged

Vertx server adapter #868

merged 3 commits into from Jul 26, 2016

Conversation

vietj
Copy link
Contributor

@vietj vietj commented Jul 14, 2016

Integration with Vert.x 3.3

@jimma
Copy link
Contributor

jimma commented Jul 26, 2016

Hi Julien,
Is callEmpty(client) in JaxrsAsyncTest for 3 times intended ?
For the new added RESTEASY1323Test , RESTEASY1325Test, if these issues are already verified by tests in resteasy-netty4 module, do we need to check in vertx module again ?
Thanks

@vietj
Copy link
Contributor Author

vietj commented Jul 26, 2016

@jimma to be honest I just copied the Netty tests as Vert.x and Netty are very similar, we can remove these tests if you think it's better - I have no strong opinion on this.

@vietj
Copy link
Contributor Author

vietj commented Jul 26, 2016

@jimma about callEmpty called 3 times, again I copied the Netty 4 tests, that do the same

@jimma
Copy link
Contributor

jimma commented Jul 26, 2016

I'll merge and fix these tests later.

@jimma jimma merged commit 6ac930f into resteasy:master Jul 26, 2016
@vietj
Copy link
Contributor Author

vietj commented Jul 26, 2016

@jimma thanks!

@vietj
Copy link
Contributor Author

vietj commented Jul 26, 2016

@jimma any idea when this will be in a Resteasy release ?

@asoldano
Copy link
Member

Likely in a beta release by the end of this week

@vietj
Copy link
Contributor Author

vietj commented Jul 26, 2016

great, don't hesitate to ping us when it's done and perhaps you can announce it to the Vert.x google group as well ?

@asoldano
Copy link
Member

I've committed a small fix to change the scope of a maven dependency, as the merged commits were breaking the build.
Besides that, I've created https://issues.jboss.org/browse/RESTEASY-1453 , can you please fill in the description / provide some details so that the addition is tracked in the release notes?
It would also be cool if you could provide a bit of documentation, otherwise we'll manage to write something ;-)

@vietj
Copy link
Contributor Author

vietj commented Jul 27, 2016

Hi,

I added a section in the Resteasy docbook, what else do you expect ?

On Jul 26, 2016, at 4:45 PM, Alessio Soldano notifications@github.com wrote:

I've committed a small fix to change the scope of a maven dependency, as the merged commits were breaking the build.
Besides that, I've created https://issues.jboss.org/browse/RESTEASY-1453 https://issues.jboss.org/browse/RESTEASY-1453 , can you please fill in the description / provide some details so that the addition is tracked in the release notes?
It would also be cool if you could provide a bit of documentation, otherwise we'll manage to write something ;-)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #868 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AANxiiMSWB3xjj6Zpg2oY7C3Ii2WzDKrks5qZh2ZgaJpZM4JMyHG.

@vietj
Copy link
Contributor Author

vietj commented Jul 27, 2016

I have added a comment as I could not find a way to edit a description in the JIRA task.

On Jul 26, 2016, at 4:45 PM, Alessio Soldano notifications@github.com wrote:

I've committed a small fix to change the scope of a maven dependency, as the merged commits were breaking the build.
Besides that, I've created https://issues.jboss.org/browse/RESTEASY-1453 https://issues.jboss.org/browse/RESTEASY-1453 , can you please fill in the description / provide some details so that the addition is tracked in the release notes?
It would also be cool if you could provide a bit of documentation, otherwise we'll manage to write something ;-)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #868 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AANxiiMSWB3xjj6Zpg2oY7C3Ii2WzDKrks5qZh2ZgaJpZM4JMyHG.

@asoldano
Copy link
Member

@vietj thanks; actually I missed the changed to the docbook, so we're fine :-)
Last thing, the VertxContainer is in package org.jboss.resteasy.test... I assume that's a mistake and I'd move that to package org.jboss.resteasy.plugins.server.vertx, ok?

@jimma
Copy link
Contributor

jimma commented Jul 27, 2016

@vietj , I removed some tests from your change and clean up some imports. Can you please have a look at this PR #883 ? If it's OK, I am going to merge it. Thanks.

@vietj
Copy link
Contributor Author

vietj commented Jul 27, 2016

@jimma n/p with me, how does 880 relates to vertx ?

@vietj
Copy link
Contributor Author

vietj commented Jul 27, 2016

@asoldano ok for moving this to a more appropriate place (I copied what netty did)

@jimma
Copy link
Contributor

jimma commented Jul 27, 2016

Should be PR #883. Sorry.

@jimma n/p with me, how does 880 relates to vertx ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants