Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git config debug logs have empty values when loading a config which does not define them #67

Open
shiouen opened this issue Jan 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@shiouen
Copy link
Member

shiouen commented Jan 17, 2024

  1. Have a config file like:
mode = "auto"

[git]

#[git.config]
#email = "semverbot@github.com"
#name = "semverbot"

[git.tags]
prefix = "v"

[semver]
patch = ["fix", "bug"]
minor = ["feature"]
major = ["release"]

[modes]

[modes.git-branch]
delimiters = "/"

[modes.git-commit]
delimiters = "[]/"
  1. log output:
12:44:19 DBG configuring git...
12:44:19 DBG user.email=
12:44:19 DBG user.name=

it is harmless, as exisiting git config would never be overwritten, but it is confusing. Would be good to make the logs more clear by showing already existing config values and configured values separately. e.g.

12:44:19 DBG configuring git...
12:44:19 DBG user.email from-git=email@email.com from-config=
12:44:19 DBG user.name from-git="Email Email" from-config=
@shiouen shiouen added the enhancement New feature or request label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant