Speed up RandomPolynomial by a factor 13 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 12, 2020 14:33
This avoids having to do the multiplication twice and speeds up Pol.Irreducible: name old time/op new time/op delta PolIrreducible-8 62.4ms ± 0% 57.4ms ± 0% -8.11% (p=0.000 n=10+10)
Benchmark results on amd64 show a 13-fold speedup: name old time/op new time/op delta PolIrreducible-8 57.4ms ± 0% 4.3ms ± 0% -92.43% (p=0.000 n=10+7) The mul2 call could be inlined in Pol.MulMod for a further 7% speedup, but the tests don't cover that. Compared to 3404fc8, we have: name old time/op new time/op delta RandomPolynomial-8 102ms ±13% 8ms ± 8% -92.55% (p=0.000 n=10+10) PolIrreducible-8 62.4ms ± 0% 4.3ms ± 0% -93.04% (p=0.000 n=10+7)
greatroar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit avoids having to do the multiplication twice and speeds up Pol.Irreducible:
The second introduces a fast path for Pol.Mul(x, 2), for a combined speedup of: