Separate buffer management and split point calculation #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chunker.Next
currently handles buffer management and the split point calculation at the same time. While experimenting with a way to also chunk Tree blobs, I noticed that this combination is a problem: trees are built incrementally such that the Chunker cannot simply read the next part of the tree into its buffer. Moving the buffer out of the Chunker helps in this case, as it allows to manage a buffer in a way that better matches what is necessary to split tree blobs.For now the PR splits the chunker into
BaseChunker
andChunker
. However, if the tree blob chunking works out as planned, then theChunker
will no longer be used by restic and could be removed unless there are other users.Performance seems to be mostly unaffected, maybe even improve a tiny bit: