Ignore unexpected files in intermediate directories #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Listing the data/ folder in a repository no longer fails if it contains files in the data/ folder. This also ignore .DS_Store files created by macOS.
MichaelEischer
force-pushed
the
skip-files-in-intermediate-directories
branch
from
82ae666
to
22a6412
Compare
|
Looks like we had zero test coverage for |
|
LGTM. |
|
Thank you Michael! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change? What does it change?
Listing the data/ folder in a repository no longer fails if it contains files in the data/ folder. This also ignores .DS_Store files created by macOS.
Was the change discussed in an issue or in the forum before?
Fixes #219.
Checklist
[ ] I have added documentation for the changes (in the manual)changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits