Restrict rest-server.service SystemCallFilter (disallow @resources and @privileged) #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
| @@ -57,6 +57,8 @@ RestrictRealtime=true | |||
| # if your service crashes with "code=killed, status=31/SYS", you probably tried to run linux_i386 (32bit) binary on a amd64 host | |||
| SystemCallArchitectures=native | |||
| SystemCallFilter=@system-service | |||
| SystemCallFilter=~@resources | |||
There was a problem hiding this comment.
For me ~@resources leads to a crash on startup due to golang/go#46279 .
|
Closing as the PR caused a crash during my tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change? What does it change?
Add more systemcalls that should not be allowed to the SystemCallFilter= in rest-server.service.
Was the change discussed in an issue or in the forum before?
Yes, in the forum
https://forum.restic.net/t/adjust-systemcallfilter-in-rest-server-service-add-resources-and-privileged/6454/4
Checklist
changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits