Refactor handlers: make Config not global

[mholt]

I know this diff looks huge, but it's actually pretty simple: instead of a global value named Config, the identifier named Config is now a struct type. Instead of having all sorts of global configuration, we confine it to that struct... and attach the handlers as methods on the struct.

It's a lot cleaner, in that CLI options are confined to main and the main() function just builds a Config struct like any other user of the library would.

This makes it possible to use the restserver package as a library.

The default configuration is still preserved.

Closes #66

/cc @rawtaz

[fd0]

This already looks very good, thanks! I've got a few comments:

• In main.go, we can just have a global instance of Config (e.g. called cfg), which can then be filled via the Cobra flags. This way, we don't have to define all the variables again. Would you mind changing that? Example in restic: https://github.com/restic/restic/blob/a9c2e84ccd664a44fa268e209c2f2a44d40d020b/cmd/restic/global.go#L67

• One thing that bugs me: Now we have a Config type which implements an HTTP server, that feels wrong to me. How about a Server with a Config field, so the methods are attached to the Server?

[mholt]

@fd0

In main.go, we can just have a global instance of Config (e.g. called cfg), which can then be filled via the Cobra flags. This way, we don't have to define all the variables again.

Great idea -- I'll get on that!

One thing that bugs me: Now we have a Config type which implements an HTTP server, that feels wrong to me. How about a Server with a Config field, so the methods are attached to the Server?

I can do that. It probably "feels wrong" because it's named Config, but it might as well be named Server or Handler. :) What if we just rename it?

[mholt]

I went ahead and renamed Config to Server, and used a single instance of it in main -- I do like this better. :)

[mholt]

I know you've been busy @fd0, so just a friendly ping in case this got lost in all the shuffle. :)

[mholt]

Any other changes you need for this? I've been using this for some time and it is working well for me.

[fd0]

This is so much better, thank you! It indeed bugged me because it was named Config. Server is a great choice.

[mholt]

Yay!! Thanks!