Non-existent exclude file causes all exclude files to be ignored

[ProactiveServices]

Output of restic version

restic 0.9.1 compiled with go1.10.3 on windows/amd64

How did you run restic exactly?

restic backup -r restic --exclude-file=exclude1.txt --exclude-file=exclude2.txt source

dir /b source
1.txt
2.txt
3.txt

type exclude1.txt
1.txt

(exclude2.txt does not exist)

restic backup -r restic --exclude-file=exclude1.txt --exclude-file=exclude2.txt source
enter password for repository:
repository 56deafac opened successfully, password is correct
error reading exclude patterns: open exclude2.txt: The system cannot find the fi

Files:           3 new,     0 changed,     0 unmodified
Dirs:            0 new,     0 changed,     0 unmodified
Added:      312 B

processed 3 files, 19 B in 0:02
snapshot 4e07390f saved

restic ls -r restic latest
enter password for repository:
repository 56deafac opened successfully, password is correct
snapshot 4e07390f of [<redacted>\testing\source] at 2018-07-18 19:25:40.5134941 +0100 BST):
/source
/source/1.txt
/source/2.txt
/source/3.txt

What backend/server/service did you use to store the repository?

Local

Expected behavior

Only 1.txt to be backed up.

Actual behavior

1.txt, 2.txt and 3.txt backed up

Steps to reproduce the behavior

Run a restic backup with a valid exclude file. List files in the repo, observe files are correctly excluded.
Add a file to the source that would be excluded by the exclude file patterns.
Run a restic backup and add an additional exclude file switch using a file name that does not exist. Observe that all exclude files are ignored. --exclude switches are accepted.

Do you have any idea what may have caused this?

I think

restic/cmd/restic/cmd_backup.go

Line 213 in 73153db

opts.Excludes = append(opts.Excludes, readExcludePatternsFromFiles(opts.ExcludeFiles)...)

may need a try/catch clause. I'm not a competent programmer so I'll leave it to someone more experienced.

Did restic help you or made you happy in any way?

It' will do when I get as far as implementing it for my customers and myself \o/

[fd0]

Whoops, this is a bug, thanks for the report! I'll have a look now.