Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gs: Respect bandwidth limiting #2100

Merged
merged 3 commits into from Nov 28, 2018
Merged

gs: Respect bandwidth limiting #2100

merged 3 commits into from Nov 28, 2018

Conversation

fd0
Copy link
Member

@fd0 fd0 commented Nov 25, 2018

What is the purpose of this change? What does it change?

In 0dfdc11, accidentally we dropped using the provided http.RoundTripper, this commits adds it back.

Was the change discussed in an issue or in the forum before?

Closes #1989

Checklist

  • I have read the Contribution Guidelines
  • I have added tests for all changes in this PR
  • I have added documentation for the changes (in the manual)
  • There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
  • I have run gofmt on the code in all commits
  • All commit messages are formatted in the same style as the other commits in the repo
  • I'm done, this Pull Request is ready for review

In 0dfdc11, accidentally we dropped
using the provided http.RoundTripper, this commits adds it back.

Closes #1989
@codecov-io
Copy link

codecov-io commented Nov 25, 2018

Codecov Report

Merging #2100 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2100      +/-   ##
==========================================
- Coverage   50.78%   50.73%   -0.06%     
==========================================
  Files         176      176              
  Lines       14165    14168       +3     
==========================================
- Hits         7194     7188       -6     
- Misses       5920     5935      +15     
+ Partials     1051     1045       -6
Impacted Files Coverage Δ
internal/backend/gs/gs.go 74% <100%> (+0.39%) ⬆️
internal/checker/checker.go 64.54% <0%> (-3.87%) ⬇️
internal/backend/s3/s3.go 60.15% <0%> (-2.26%) ⬇️
internal/archiver/file_saver.go 88.59% <0%> (+7.01%) ⬆️
internal/archiver/blob_saver.go 100% <0%> (+7.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2434ab2...6f5c3e5. Read the comment docs.

@fd0 fd0 merged commit 6f5c3e5 into master Nov 28, 2018
@fd0 fd0 deleted the fix-1989 branch November 28, 2018 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants