Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rclone: Rework backend option parsing #2193

Merged
merged 1 commit into from Mar 16, 2019
Merged

rclone: Rework backend option parsing #2193

merged 1 commit into from Mar 16, 2019

Conversation

fd0
Copy link
Member

@fd0 fd0 commented Mar 2, 2019

What is the purpose of this change? What does it change?

This change allows passing no arguments to rclone, using -o rclone.args="". It is helpful when running rclone remotely via SSH
using a key with a forced command (via command= in authorized_keys).

Was the change discussed in an issue or in the forum before?

On IRC

Checklist

  • I have read the Contribution Guidelines
  • I have added tests for all changes in this PR
  • I have added documentation for the changes (in the manual)
  • [-] There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
  • I have run gofmt on the code in all commits
  • All commit messages are formatted in the same style as the other commits in the repo
  • I'm done, this Pull Request is ready for review

This change allows passing no arguments to rclone, using `-o
rclone.args=""`. It is helpful when running rclone remotely via SSH
using a key with a forced command (via `command=` in `authorized_keys`).
@codecov-io
Copy link

codecov-io commented Mar 2, 2019

Codecov Report

Merging #2193 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2193      +/-   ##
==========================================
+ Coverage   50.76%   50.77%   +0.01%     
==========================================
  Files         176      176              
  Lines       14251    14244       -7     
==========================================
- Hits         7234     7232       -2     
+ Misses       5964     5958       -6     
- Partials     1053     1054       +1
Impacted Files Coverage Δ
internal/backend/rclone/backend.go 66.66% <ø> (+2.33%) ⬆️
internal/backend/rclone/config.go 81.81% <100%> (-1.52%) ⬇️
internal/archiver/file_saver.go 85.96% <0%> (-2.64%) ⬇️
internal/archiver/blob_saver.go 97.53% <0%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b8d1dc...3865b59. Read the comment docs.

@fd0 fd0 merged commit 3865b59 into master Mar 16, 2019
@fd0 fd0 deleted the allow-empty-rclone-args branch April 13, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants