Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: selfupdate: 'writing restic to' as verbose #3535

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

jtagcat
Copy link
Contributor

@jtagcat jtagcat commented Oct 2, 2021

Running restic self-update --quiet no longer
prints "writing restic to /usr/local/bin/restic".

The only output printed with -q is failures or
"successfully updated restic to version 0.12.1"

#3535

What does this PR change? What problem does it solve?

| Using grep -v for auto-upgrade logs.

Was the change previously discussed in an issue or on the forum?

It's been on my mind for a while, I thought not. Turns out: Closes #3350

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

Copy link
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is small enough that we shouldn't need a changelog entry, please remove it and then squash all commits into one.

jtagcat added a commit to jtagcat/restic that referenced this pull request Oct 9, 2021
Running restic self-update --quiet no longer
prints "writing restic to /usr/local/bin/restic".

The only output printed with -q is failures or
"successfully updated restic to version 0.12.1"

restic#3535

fix test fail: changelog title can't end with `.`

shorten changelog title
Running restic self-update --quiet no longer
prints "writing restic to /usr/local/bin/restic".

The only output printed with -q is failures or
"successfully updated restic to version 0.12.1"

restic#3535

fix test fail: changelog title can't end with `.`

shorten changelog title
Copy link
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the cleanup.

@MichaelEischer MichaelEischer merged commit 46d08d9 into restic:master Oct 9, 2021
@jtagcat jtagcat deleted the writingverbose branch October 9, 2021 21:27
mfrischknecht pushed a commit to mfrischknecht/restic that referenced this pull request Jun 14, 2022
Running restic self-update --quiet no longer
prints "writing restic to /usr/local/bin/restic".

The only output printed with -q is failures or
"successfully updated restic to version 0.12.1"

restic#3535

fix test fail: changelog title can't end with `.`

shorten changelog title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

self-update: -q doesn't quiet 'writing restic to'
2 participants