Provide mode in symbolic notation for restic ls --json
#3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magandrez
changed the title
restic ls --json
There was a problem hiding this comment.
That changelog needs a small changes. Besides that the code seems fine, although I'd like to wait with merging until #3575 has been merged which should fix the test failure.
This aligns `restic ls --json` with `restic find --json`, utilizing the same naming.
magandrez
force-pushed
the
feat/ls-report-symbolic-notation
branch
from
7b232ec
to
212b2f6
Compare
|
@MichaelEischer this is ready from my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds "permissions" to the JSON output in symbolic notation, just as
restic find --jsondoes, and utilizing the samenaming.
What does this PR change? What problem does it solve?
#3542
This change outputs permissions in symbolic notation for
restic ls --jsonjust asrestic find --jsondoesaligned with the naming used in
findcommand.Was the change previously discussed in an issue or on the forum?
Yes
https://forum.restic.net/t/restic-ls-understanding-file-mode-with-json/4371/6
closes #3542
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.