Remove existing path before restoring a symlink #3780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: Make sure that symlinks can be created during recovery
When restoring a symlink, restic reported an error if the target path already existed.
With this change, the potentially existing target path is first removed before the symlink is recreated.
#2578
What does this PR change? What problem does it solve?
At the moment restic overwrites existing data in the restore target, unless it is a symlink, in which case an error is thrown.
From my point of view, restic should behave with symlinks in the same way as with all other file types and "overwrite" already existing paths.
This change causes restic to "overwrite" existing data (by delete and create) even if a symlink is to be restored.
See #2578 for more details.
Was the change previously discussed in an issue or on the forum?
Closes #2578
Checklist