Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sftp: Only connect once to server during init #3882

Merged

Conversation

MichaelEischer
Copy link
Member

What does this PR change? What problem does it solve?

This is especially useful if ssh asks for a password or if closing the initial connection could return an error due to a problematic server implementation.

Was the change previously discussed in an issue or on the forum?

Fixes #2152

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • [ ] I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

This is especially useful if ssh asks for a password or if closing the
initial connection could return an error due to a problematic server
implementation.
@MichaelEischer MichaelEischer merged commit 582167d into restic:master Aug 26, 2022
@MichaelEischer MichaelEischer deleted the sftp-init-single-connection branch August 26, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sftp crash on init after creating all folders
1 participant