Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only display the message if there were locks to be removed #3935

Merged
merged 1 commit into from Sep 24, 2022

Conversation

miles170
Copy link
Contributor

What does this PR change? What problem does it solve?

restic unlock should only show successfully removed locks if there were locks to be removed.

Was the change previously discussed in an issue or on the forum?

Closes #3929

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

Copy link
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general approach is fine, but I found a few things that have to be changed before merging.

changelog/unreleased/pull-3935 Outdated Show resolved Hide resolved
internal/restic/lock.go Outdated Show resolved Hide resolved
internal/restic/lock.go Outdated Show resolved Hide resolved
changelog/unreleased/pull-3935 Outdated Show resolved Hide resolved
changelog/unreleased/pull-3935 Outdated Show resolved Hide resolved
`restic unlock` now only shows `successfully removed locks` if there were locks to be removed.
In addition, it also reports the number of the removed lock files.
Copy link
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the unlock output more helpful.

@MichaelEischer MichaelEischer merged commit eb83402 into restic:master Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Successfully removed locks
2 participants