Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount: switch to anacrolix fork of bazil/fuse #4024

Merged
merged 1 commit into from Nov 26, 2022

Conversation

MichaelEischer
Copy link
Member

@MichaelEischer MichaelEischer commented Nov 12, 2022

What does this PR change? What problem does it solve?

Replace the bazil/fuse library with the anacrolix fork.

The anacrolix fork contains the latest changes from bazil/fuse and additionally provides support for recent versions of macFUSE.

Unfortunately, there seems to be no actively maintained fork of bazil/fuse, such that we'll likely have to switch to a different fuse library sooner or later.

Was the change previously discussed in an issue or on the forum?

Fixes #3096

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • [ ] I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

Copy link

@enj enj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should test_fuse be set to true for macOS?

@MichaelEischer
Copy link
Member Author

I've enabled the fuse tests for macOS. Let's see whether these work reliably.

The anacrolix fork contains the latest changes from bazil/fuse and
additionally provides support for recent versions of macFUSE.
@MichaelEischer
Copy link
Member Author

Hmm, the fuse tests failed as macFUSE is not available. According to actions/runner-images#5583 (comment) this cannot be fixed using the official CI Runners. So, I guess this will just have to work without test coverage :-( .

@MichaelEischer MichaelEischer merged commit 9113b26 into restic:master Nov 26, 2022
@MichaelEischer MichaelEischer deleted the macos-fuse branch November 26, 2022 11:15
@anacrolix
Copy link

american-psycho-patrick-bateman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS: drop fuse support (restic mount)
3 participants