Require go 1.18 #4041
Merged
Require go 1.18 #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
force-pushed
the
require-go-1.18
branch
from
4866cc9
to
4300f79
Compare
|
github.com/hashicorp/golang-lru/v2 would also require 1.18. |
|
Code changes LGTM. I suppose this (or any upgrade to >=1.16) would also close #2659. |
greatroar
reviewed
Nov 27, 2022
MichaelEischer
force-pushed
the
require-go-1.18
branch
from
4300f79
to
97c7fc5
Compare
Our minimum go version is new enough to allow updating the library.
MichaelEischer
force-pushed
the
require-go-1.18
branch
from
97c7fc5
to
530f129
Compare
|
LGTM. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
#4038 and #4028 require Go 1.18 to build. This rather large bump in the required minimum version is a result of making use of the generics support which was introduced in Go 1.18.
This PR also cleans up some no longer necessary workarounds and build constraints.
Was the change previously discussed in an issue or on the forum?
See #4028.
Checklist
[ ] I have added tests for all code changes.changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.