Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect sftp connection #4058

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Reconnect sftp connection #4058

wants to merge 2 commits into from

Conversation

ibash
Copy link

@ibash ibash commented Nov 29, 2022

Draft PR for #353

TODO:

  • Cleanup
  • Thread safety
  • More testing

The retry mechanism indicates that 10 retries should be done. But it seems like more than 10 reconnections are done, I'd like to find out why.

--

What does this PR change? What problem does it solve?

Was the change previously discussed in an issue or on the forum?

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

@MichaelEischer
Copy link
Member

  • Thread safety

You should probably start with a mutex around the reconnect() method. But you'll probably need a way to prevent multiple reconnections, if multiple uploads fail for the same reason.

  • The retry mechanism indicates that 10 retries should be done. But it seems like more than 10 reconnections are done, I'd like to find out why.

The retries are per file. Restic by default uploads up to 5 pack files in parallel. This will probably need some upper limit for the number of reconnections.

In general, reconnecting should probably be opt-in as not everyone has setup password-less ssh.

@MichaelEischer MichaelEischer linked an issue Jul 29, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sftp backend does not reconnect
2 participants