sftp: Fix ENOSPC check #4075
Merged
sftp: Fix ENOSPC check #4075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now check for space that is not reserved for the root user on the remote, and the check is no longer in a defer block because it wouldn't fire. Some change in the surrounding code may have led the deferred function to capture the wrong err variable. Fixes restic#3336.
MichaelEischer
approved these changes
Dec 7, 2022
|
@MichaelEischer Done. |
greatroar
commented
Dec 7, 2022
greatroar
force-pushed
the
sftp-enospc
branch
from
46bfcc7
to
83d23b3
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
There were two bugs in the "no space left on device" check in the SFTP backend. With this patch, we check for space that is not reserved for the root user on the remote, and the check is no longer in a defer block because that wouldn't fire. Some change in the surrounding code may have led the deferred function to capture the wrong err variable.
Was the change previously discussed in an issue or on the forum?
Fixes #3336. Tested on Linux by backing up to an 8MiB ext2 image that has 50% space reserved for root.
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.