Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: change error code in function isAccessDenied to AccessDenied #4086

Merged
merged 2 commits into from Dec 16, 2022

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Dec 13, 2022

Signed-off-by: Xun Jiang blackpiglet@gmail.com

What does this PR change? What problem does it solve?

It's used to fix issue #4085

Was the change previously discussed in an issue or on the forum?

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

Copy link
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Xun Jiang and others added 2 commits December 16, 2022 21:41
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
Co-authored-by: greatroar <61184462+greatroar@users.noreply.github.com>
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
@MichaelEischer
Copy link
Member

I've rebased the PR and slightly shortened the title of the changelog entry to fix the test failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants