in tar dump, convert uid, gid of value -1 to zero #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatroar
reviewed
Dec 28, 2022
|
LGTM. My suggestion of comparing to -1 is just that, a suggestion. |
|
Hi @MichaelEischer, you can retry the PR run. |
Only for a 32-bit build of restic, convert a uid or gid value of -1 to 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
This solves issue #4103. See #4103 and discussion #4102.
Was the change previously discussed in an issue or on the forum?
Yes, see #4103 and discussion #4102.
Checklist
Comments on checklist: I did not write a new test, because the change is simple. I have run the tests though. The change is internal, so there is no change in the manual.
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.