Add a global option --retry-lock #4107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
force-pushed
the
feature-wait-for-unlock
branch
from
17ff0e4
to
00704b9
Compare
MichaelEischer
requested changes
Feb 10, 2023
jooola
force-pushed
the
feature-wait-for-unlock
branch
2 times, most recently
from
790e4b4
to
8121549
Compare
MichaelEischer
approved these changes
Apr 7, 2023
jooola
force-pushed
the
feature-wait-for-unlock
branch
from
5dfa011
to
95a7f0f
Compare
Fixes restic#719 If the option is passed, restic will wait the specified duration of time and retry locking the repo every 10 seconds (or more often if the total timeout is relatively small). - Play nice with json output - Reduce wait time in lock tests - Rework timeout last attempt - Reduce test wait time to 0.1s - Use exponential back off for the retry lock - Don't pass gopts to lockRepo functions - Use global variable for retry sleep setup - Exit retry lock on cancel - Better wording for flag help - Reorder debug statement - Refactor tests - Lower max sleep time to 1m - Test that we cancel/timeout in time - Use non blocking sleep function - Refactor into minDuration func Co-authored-by: Julian Brost <julian@0x4a42.net>
jooola
force-pushed
the
feature-wait-for-unlock
branch
from
95a7f0f
to
ea59896
Compare
|
|
Hmm, it looks like the durations checks are too strict: I've broadened them quite a bit, but I fear these might become another |
MichaelEischer
force-pushed
the
feature-wait-for-unlock
branch
from
fcf3c02
to
8ce5f29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to resurrect #2214
What does this PR change? What problem does it solve?
If the option is passed, restic will wait the specified duration of time and retry locking the repo every 10 seconds (or more often if the total timeout is relatively small).
Was the change previously discussed in an issue or on the forum?
Fixes #719
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.