Fix scan_finished JSON MessageType #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
force-pushed
the
fix/impostor
branch
from
b3e202a
to
7982054
Compare
Corrected the scan_finished JSON MessageType from status to verbose_status
MichaelEischer
force-pushed
the
fix/impostor
branch
from
7982054
to
1b50faf
Compare
MichaelEischer
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
This PR corrects the
MessageTypeof theverboseUpdatestruct which is printed by theReportTotalfunction, theMessageTypeis currently set tostatusinstead ofverbose_status, This causes the message to be misidentified as astatusUpdatewhen deserializing JSON.Was the change previously discussed in an issue or on the forum?
Not that I'm aware of.
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.