Add smb backend #4186
Open
Add smb backend #4186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* backend/smb: Add SMB backend and testcases Add new SMB storage backend for restic. Added test cases for testing SMB backend. --------- Co-authored-by: Aneesh Nireshwalia <aneeshynot@gmail.com> Co-authored-by: Srigovind Nayak <sgovind.dev@outlook.com>
Removed extra environment variables
Add documentation for configuring smb repository. Clean up configuration for smb. Renamed address to host. Add option to configure user in smb repo url as well. Options take highest precendence.
|
I have hard coded the SMB credentials as it runs a local test by installing Samba for Linux, configures SmbShare for Windows and configures smb file 'sharing' for Mac. |
Fix the check for macOS which was failing after commenting brew install.
greatroar
reviewed
Jan 31, 2023
|
Parts of this code have been copied from rclone. That means the rclone license should appear somewhere in it:
|
greatroar
reviewed
Jan 31, 2023
Add rclone copyright notice for smb files. Change temp file creation code to match sftp code. Remove fastrand dependency.
greatroar
reviewed
Feb 5, 2023
Setting *pc back to nil is too easily defeated to be useful. This is more concise and prevents pointer from getting heap-allocated.
Corrected the variable name for smbuser
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Correct method definition for unused param ctx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Adds SMB as a new storage backend in restic. Currently for backing up to SMB, it has to be mounted on the OS or rclone needs to be used. With this change it will be possible to specify SMB details and restic will directly make SMB connections to do the backups.
Was the change previously discussed in an issue or on the forum?
Closes #4185
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.