Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jq to container image #4220

Merged
merged 1 commit into from Apr 11, 2023
Merged

Add jq to container image #4220

merged 1 commit into from Apr 11, 2023

Conversation

Skaronator
Copy link
Contributor

@Skaronator Skaronator commented Feb 21, 2023

What does this PR change? What problem does it solve?

Many commands in Restic already allow JSON as output (restic snapshots --json). Therefore, it would be very helpful if the official container image contains jq which can be very useful for scripts or simple inline commands.

One example I'd like to use would be this command: restic diff $(restic snapshots --json | jq -r '.[-2:][].id') It shows the diff from the last 2 snapshots.

Was the change previously discussed in an issue or on the forum?

Not that I know.

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

Copy link
Member

@fd0 fd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me :)

@MichaelEischer
Copy link
Member

Just for documentation: we'd like to keep the docker image rather minimal, but jq is probably worth an exception.

@MichaelEischer MichaelEischer merged commit 4661f45 into restic:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants