Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certificates can be passed through env vars #4384

Merged
merged 2 commits into from Jul 8, 2023

Conversation

arjunajesh
Copy link
Contributor

What does this PR change? What problem does it solve?

This pull request enables the user to pass certificate files through environment variables (RESTIC_CACERT, RESTIC_TLS_CERT), instead of manually passing the file with --cacert or --tls-client-cert.

Was the change previously discussed in an issue or on the forum?

Yes it was discussed in an issue: #1926
Closes #1926

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

Copy link
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this issue. The PR still needs a few changes, I've added corresponding comments below. The new environment variables should also be added to the list in doc/040_backup.rst.

.DS_Store Outdated Show resolved Hide resolved
cmd/restic/global.go Outdated Show resolved Hide resolved
changelog/unreleased/issue-1926 Show resolved Hide resolved
changelog/unreleased/issue-1926 Outdated Show resolved Hide resolved
Copy link
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've rebased the PR and added some further small cleanups.

@MichaelEischer MichaelEischer added this pull request to the merge queue Jul 8, 2023
Merged via the queue into restic:master with commit 7e2be9e Jul 8, 2023
11 checks passed
@arjunajesh arjunajesh deleted the issue#1926 branch July 8, 2023 19:53
@MichaelEischer MichaelEischer mentioned this pull request Jul 9, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: pass cacert and tls-client-cert content as environment variables
2 participants