azure domain can be overridden with env variable #4387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunajesh
changed the title
MichaelEischer
requested changes
Jul 1, 2023
There was a problem hiding this comment.
Thanks for working on this issue! The PR currently still needs a bit of polishing, see the comments below. The comments also explain where to add documentation. For testing it should be sufficient to manually verify that the parameter works as intended and does not change the current behavior is no other azure endpoint is specified.
|
I have fixed everything you mentioned. Thanks for the help! |
MichaelEischer
force-pushed
the
issue#2468
branch
from
a2bee0b
to
e36d17a
Compare
MichaelEischer
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Restic backups on azure only worked for storages on the global domain
core.windows.net. This meant that backups to other domains such as Azure China (core.chinacloudapi.cn') were not supported. Restic now allows overriding the global domain using the environment variableAZURE_DOMAIN'.Was the change previously discussed in an issue or on the forum?
Closes #2468
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.