Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically adjust GOMAXPROCS when run in a cpu-constrained container #4485

Merged
merged 1 commit into from Oct 17, 2023

Conversation

MichaelEischer
Copy link
Member

What does this PR change? What problem does it solve?

When running restic in a Linux container with CPU-usage limits, restic now
automatically adjusts GOMAXPROCS. This helps to reduce the memory consumption
on hosts with many CPU cores.

Was the change previously discussed in an issue or on the forum?

Fixes #4128

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • [ ] I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

Copy link
Member Author

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MichaelEischer MichaelEischer merged commit c635e30 into restic:master Oct 17, 2023
12 checks passed
@MichaelEischer MichaelEischer deleted the uber-automaxprocs branch October 17, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically set GOMAXPROCS to match Linux container CPU quota.
1 participant