Make key list command honor --no-lock
#4514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grembo
force-pushed
the
key-list-no-lock
branch
from
8872d79
to
2f381aa
Compare
grembo
changed the title
key list command honour --no-lockkey list command honor --no-lock
MichaelEischer
requested changes
Oct 17, 2023
Yeah, the CLI methods have fairly little test coverage. I think we can skip adding a test, just make sure to manually test that |
MichaelEischer
force-pushed
the
key-list-no-lock
branch
from
682e76b
to
34f3b13
Compare
MichaelEischer
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4513
What does this PR change? What problem does it solve?
Don't lock repo if
--no-lockflag was used as inrestic key list --no-listWas the change previously discussed in an issue or on the forum?
#4513
Checklist
I have added tests for all code changes.It seems like there are no unit tests for --no-lock besides TestCheckRestoreNoLock anywhere, so I think this should be part of a bigger effort to add such tests.
I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.