Don't load password when autocompleting CLI commands #4524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
force-pushed
the
fix-autocompletion
branch
2 times, most recently
from
b772492
to
9e03f14
Compare
rawtaz
changed the title
rawtaz
requested changes
Oct 23, 2023
MichaelEischer
force-pushed
the
fix-autocompletion
branch
from
9e03f14
to
cd09ef4
Compare
rawtaz
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Don't load the repository password when autocompleting CLI commands. This can break autocompletion if for example
RESTIC_PASSWORD_FILEis set to an invalid path.Was the change previously discussed in an issue or on the forum?
Fixes #4516
Checklist
[ ] I have added tests for all code changes.Manually tested.[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.